Skip to content

docs: fix godoc rendering and restore full AGENTS.md mirror - #80

Merged
MasterOfBinary merged 2 commits into
masterfrom
docs/align-with-repo
Jun 11, 2026
Merged

docs: fix godoc rendering and restore full AGENTS.md mirror#80
MasterOfBinary merged 2 commits into
masterfrom
docs/align-with-repo

Conversation

@MasterOfBinary

@MasterOfBinary MasterOfBinary commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • AGENTS.md: restored as a full, agent-neutral mirror of CLAUDE.md (replacing the old ChatGPT-specific copy), with cross-references in both files so they stay in sync — agents that inline AGENTS.md without following links get complete instructions again
  • CLAUDE.md: replaced the stale "maintain backward compatibility" rule with the version 0 policy plus a docs-update checklist that names the real doc surfaces (all four doc.go files and the example tests); added [T] to the Key Concepts to match the post-generics API; fixed the missing trailing newline
  • batch/doc.go: rejoined the package comment that a stray blank line had detached — the batching priority rules (MaxTime = MaxItems > EOF > MinTime > MinItems) and worked examples were silently absent from pkg.go.dev; corrected the batch-timing sentence (windows open when the previous batch is dispatched, and batches process concurrently — not "when the previous batch finished processing")
  • batch/config.go: removed the duplicate package comment (godoc was set to render two competing "Package batch" intros); documented Config.Get accurately — implementations return values as provided, Batch normalizes them, and a zero MaxItems/MaxTime means no maximum applies
  • godoc lists: indented the dash lists in batch/doc.go, processor/doc.go, source/doc.go, and NewDynamicConfig so they render as lists instead of run-on paragraphs
  • processor/doc.go: dropped the blanket "respects context cancellation" claim (Transform, Filter, and Error do not check ctx)
  • codecov.yml (new): sets a 1% threshold on the codecov/project status — the suite has scheduler-dependent paths, so total coverage varies slightly between identical runs, and the default 0% threshold failed this doc-only PR on −0.06% measurement noise

Doc/comment-only change apart from the codecov config — no behavior changes.

Test plan

  • gofmt -l . clean, go vet ./... clean
  • go test -race -covermode=atomic ./... passes (batch 98.4%, processor 98.2%, source 95.8%)
  • Verified rendered output of go doc ./batch, go doc ./processor, go doc ./source, go doc ./batch Config, and go doc ./batch NewDynamicConfig
  • codecov.yml validated against https://codecov.io/validate; all four checks green on the final head (build 1.25.x/1.26.x, codecov/patch, codecov/project)

🤖 Generated with Claude Code

- Restore AGENTS.md as a full, agent-neutral mirror of CLAUDE.md with
  cross-references so the two files stay in sync
- Replace the stale backward-compatibility rule with the version 0 policy
  and a docs-update checklist naming the real doc surfaces
- Rejoin batch/doc.go's package comment so the batching priority rules
  render on pkg.go.dev again, and correct the batch-timing sentence
  (windows open at dispatch, not when the previous batch finishes)
- Remove the duplicate package comment in batch/config.go
- Document Config.Get accurately: Batch normalizes values via fixConfig;
  a zero MaxItems/MaxTime means no maximum applies
- Indent dash lists in batch, processor, and source docs so godoc
  renders them as lists instead of run-on paragraphs
- Drop processor/doc.go's blanket context-cancellation claim
  (Transform, Filter, and Error do not check ctx)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.73%. Comparing base (66070eb) to head (fa6ad7c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   96.79%   96.73%   -0.06%     
==========================================
  Files          12       12              
  Lines         374      368       -6     
==========================================
- Hits          362      356       -6     
  Misses          9        9              
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation across several files, including AGENTS.md, CLAUDE.md, and package-level doc files. Key updates include renaming ChatGPT instructions to Agent Instructions, documenting that breaking changes are acceptable on master for this version 0 library, updating key concepts to use generic types (e.g., Batch[T]), and clarifying configuration normalization and concurrent batch processing behavior. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

The suite has scheduler-dependent paths, so total coverage varies
slightly between identical runs; the default 0% threshold fails
doc-only PRs on measurement noise.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant