Preserve carriage returns in XLSX string values - #252
Open
levvs-one wants to merge 1 commit into
Open
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The XLSX string encoder does not currently escape CR (
U+000D). The XML writer's newline handling then changes CR and CRLF to LF, so writing and reading a string such as"a\rb"does not preserve the original value.This change adds CR to the existing
OpenXmlCodecescape regex, producing_x000d_before XML serialization. It keeps the current codec, literal-escape protection and public APIs unchanged.Tests
SylvanExcelTestDatawas unset, so the optional external corpus was not exercised.The patch only changes CR escaping in the existing XLSX path; it does not change reader whitespace policy or add a different string codec.