Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves editor-ready listener resilience so one failing callback does not block subsequent listeners.
Changes:
- Adds guarded editor-ready notification.
- Updates editor reset to use the notifier.
- Adds regression coverage for queued listeners.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CoreEditor/src/api/methods.ts |
Adds isolated listener notification. |
CoreEditor/src/core.ts |
Uses the new notifier during reset. |
CoreEditor/test/api.test.ts |
Tests continuation after listener failure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Glad this led somewhere useful. Thanks for tracking it down, this looks like a much more solid fix than anything I could have worked around on my end! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As inspired by #1676.