Allow for more style configuration - #925
Open
sulabi wants to merge 13 commits into
Open
Conversation
…uping add components/module_view.rs so that modules can return structured content which can store the module's members instead of a single transformed Element. This fixes hover and click issues onto individual elements.
sulabi
marked this pull request as ready for review
August 19, 2026 01:51
Owner
|
This is interesting, but we should discuss this before merging. We need to make a new release soon, so this cannot be included in the next release; the next release will include the new style configuration settings. Also, the module configuration should live in its dedicated PR to simplify the review process. Let's try to split the changes into dedicated PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for more in depth configuration of the bar.
Before you could only set the bar to either a
BarSurface::SolidorBarSurface::Transparent, now you would be able to set the config and other bar fields individually within the config. AlthoughBarSurfacehas been removed for this approach, I still allow for it to be within configs just for backwards compatibility for older configs though is labelled as deprecated.BarAppearanceis now defined as shown below and is configured throughappearance.bar.The previous
appearance.opacityfield has been removed in favor of a structappearance.bar.opacity. Opacity is split into three values.Here are the defaults for the
opacityfield, making the appearance of the bar transparent by default.Defaults are:
It's now possible to configure appearance of individual modules through the newly added
appearance.modulesfield:ModuleNamealso now accepts a snake_case variant of the module name with deserializing, so that modules can be configured likesystem_inforather thanSystemInfo.Each module can configure the following appearance properties and there could easily be more to come:
The new
ModuleGroupenum is to change how a module and its members are grouped visuallyCombinedis default and has the same visual pre change.Individualis when you want the members of a module to have their own background or border instead of the singular parent shared for all members.For example:
Which display as:

In order to allow modules for its members to be individually displayed the return for the
viewfunction declared in each of the modules had to be changed fromiced::Elementinto the newly addedModuleView.ModuleViewallows multiple elements to not be converted into aniced::Elementuntil after styling is applied to each member. Before this would not be possible because once the conversion of aRowbe made into anElementchildren of that row could not be modified.If there is anything you would like me to do please let me know as this is my first time doing such a large pull request, also docs are incomplete for now until everything else is ready.