feat(audio): implement volume change audio notifications - #558
Open
romanstingler wants to merge 1 commit into
Open
feat(audio): implement volume change audio notifications#558romanstingler wants to merge 1 commit into
romanstingler wants to merge 1 commit into
Conversation
romanstingler
force-pushed
the
feature/audio-beep
branch
from
March 27, 2026 13:36
85ef1f8 to
f3fe0aa
Compare
romanstingler
force-pushed
the
feature/audio-beep
branch
from
April 8, 2026 16:18
f3fe0aa to
f9448df
Compare
Owner
|
I was thinking that now that we were able to reduce the number of dependencies we could evaluate to use rodio. We should probably need to add some dependency in the package and nix config to be able to compile. So we could proceed by step. If this solution is acceptable let's merge and see, then if it's used and adding rodio is not a pain in the ass we can proceed adding a "real" audio support |
romanstingler
force-pushed
the
feature/audio-beep
branch
from
April 30, 2026 19:15
f9448df to
87a6d23
Compare
romanstingler
marked this pull request as ready for review
April 30, 2026 19:15
Collaborator
Author
|
agree, we can add this one and if there is more demand we can just rework it. |
Owner
|
Does this still make sense? |
Collaborator
Author
|
@MalpenZibo I think people still want this |
Owner
|
@romanstingler ok! let's try |
romanstingler
force-pushed
the
feature/audio-beep
branch
2 times, most recently
from
August 10, 2026 20:05
7bf32f0 to
072605f
Compare
Collaborator
Author
|
@MalpenZibo ready to test |
romanstingler
force-pushed
the
feature/audio-beep
branch
from
August 21, 2026 17:27
072605f to
e5d2110
Compare
garro95
reviewed
Sep 6, 2026
| if let Some(service) = self.service.as_mut() { | ||
| if let Some(value) = message.value() { | ||
| let _ = service.command(AudioCommand::SourceVolume(value)); | ||
| self.audio_feedback.play(value); |
There was a problem hiding this comment.
Feedback on source volume change seems unusual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #525 and the follow-up conversation.
After we agreed to move away from spawning external processes (
pw-cat), I first looked intorodiobut that would pull inlibasound2-devas an additional system dependency, which I wanted to avoid to keep the dependency footprint small.Instead I switched to
libpulse-simple-bindingwhich reuses the already requiredlibpulse.so, so no new system library is needed while still giving us "real" audio playback.What changed from the original approach:
assets/bell.pcm) played directly via PulseAudio's simple API.(I tried to synthesize this one but it is too complex and sounds really off otherwise).
audio_feedbackis configurable in[settings](default:true), and hot-reloadable.@MalpenZibo your call on the default value
Docs updated accordingly.
closes #525