Skip to content

Fix throughput-spike OTA timeout build by defining work item before use - #73

Merged
MacNite merged 1 commit into
claude/blissful-turing-8edvzofrom
codex/fix-build-error-in-ota.c
Sep 7, 2026
Merged

Fix throughput-spike OTA timeout build by defining work item before use#73
MacNite merged 1 commit into
claude/blissful-turing-8edvzofrom
codex/fix-build-error-in-ota.c

Conversation

@MacNite

@MacNite MacNite commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The spike variant failed to build because the spike-only helper ota_release_arm_timeout() referenced arm_timeout_work before that delayable work item was defined, which only occurs when ENABLE_THROUGHPUT_SPIKE is enabled.

Description

  • Adjusted firmware-nrf54lm20a/src/ota.c so the reboot/stall handler declarations and the K_WORK_DELAYABLE_DEFINE for arm_timeout_work, reboot_work, and stall_timeout_work appear before the #if ENABLE_THROUGHPUT_SPIKE block, allowing ota_release_arm_timeout() to reference arm_timeout_work without compile errors.
  • This is strictly a source-order fix and does not change runtime behavior for non-spike builds.

Testing

  • git diff --check completed with no new warnings or errors.
  • A source-order assertion (Python check) verified the K_WORK_DELAYABLE_DEFINE for arm_timeout_work now precedes the ota_release_arm_timeout() helper.
  • west build for the spike variant was not executed here because the Nordic/Zephyr sysbuild toolchain is not available in this environment, so a full rebuild remains recommended on a machine with the SDK installed.

Codex Task

@MacNite
MacNite merged commit 4bb72db into claude/blissful-turing-8edvzo Sep 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant