馃摉 [Docs]: Ready-for-review guidance now rejects missing CI checks - #147
Merged
Marius Storhaug (MariusStorhaug) merged 4 commits intoAug 9, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Marius Storhaug (MariusStorhaug)
marked this pull request as ready for review
August 2, 2026 17:02
Marius Storhaug (MariusStorhaug)
enabled auto-merge (squash)
August 2, 2026 17:05
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Marius Storhaug (MariusStorhaug)
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Marius Storhaug (MariusStorhaug)
changed the title
Marius Storhaug (MariusStorhaug)
marked this pull request as draft
August 9, 2026 18:42
auto-merge was automatically disabled
August 9, 2026 18:42
Pull request was converted to draft
Marius Storhaug (MariusStorhaug)
marked this pull request as ready for review
August 9, 2026 18:43
Marius Storhaug (MariusStorhaug)
deleted the
clarify-checks-gate-when-no-checks-run
branch
August 9, 2026 18:43
5 tasks
Marius Storhaug (MariusStorhaug)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready-for-review pull requests now treat missing CI checks as an unmet gate. The Definition of Ready and Done explains why a manually dispatched workflow does not establish pull-request verification, and why auto-merge cannot compensate for a ruleset with no required status checks.
Changed: Missing checks no longer satisfy the review gate
A pull request that reports no checks has not met the required-checks item. The guidance identifies an uncovered
pull_requesttrigger as the usual cause, requires the gap to be fixed or tracked, and explains that a greenworkflow_dispatchrun can omit event-gated jobs without proving that they passed. When checks genuinely cannot run before merge, the pull request must state that fact and link its tracking issue.Changed: Auto-merge now reflects the ruleset it enforces
Auto-merge waits only for the checks and approvals the branch ruleset declares. The guidance now identifies a missing required-status-check rule as a configuration breach to fix, rather than a condition contributors should work around by watching builds manually.
Technical details
src/docs/Ways-of-Working/Definition-of-Ready-and-Done.mdwithout changing headings or anchors.src/docs/Ways-of-Working/**(prose)Relevant issues (or links)
Related work