Fix broken APIs and hardcoded wandb entity in Classification Transformers#231
Open
ArneshBanerjee wants to merge 1 commit into
Open
Fix broken APIs and hardcoded wandb entity in Classification Transformers#231ArneshBanerjee wants to merge 1 commit into
ArneshBanerjee wants to merge 1 commit into
Conversation
…mers torchmetrics 0.11+ requires task= for auroc and accuracy, and micro_auroc was never appended to so it always returned NaN. softmax on eval.py:172 was missing dim=-1. CosineAnnealingWarmRestarts no longer takes verbose= in newer PyTorch. torch.has_mps is deprecated, replaced with torch.backends.mps.is_built(). Hardcoded entity="_archil" in train.py and eval.py broke W&B for anyone else, so removed it. Fixes ML4SCI#191, ML4SCI#192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191, #192
Several things in
DeepLense_Classification_Transformers_Archil_Srivastavathat break with current library versions: torchmetrics 0.11+ needstask="multiclass"on auroc/accuracy calls,micro_aurocwas declared but never appended to so it silently returned NaN,softmaxon eval.py:172 was missingdim=-1,verbose=Truewas removed fromCosineAnnealingWarmRestartsin newer PyTorch, andtorch.has_mpsis deprecated. Also removed the hardcodedentity="_archil"from both train and eval so W&B runs work for other contributors.