Skip to content

Add cookie snapshotting for connection transfer #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milutinke merged 1 commit into from
Aug 27, 2026
Merged

Add cookie snapshotting for connection transfer #3213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MinecraftClient/McClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,9 @@ public void Transfer(string newHost, int newPort)

ResetStateForTransfer();

// Snapshot cookies before Dispose clears them
Dictionary<string, byte[]> savedCookies = new Dictionary<string, byte[]>(Cookies);

// Retire the old handler so its updater exits without reporting a stale disconnect.
oldHandler.Dispose();
oldClient.Close();
Expand All @@ -457,6 +460,7 @@ public void Transfer(string newHost, int newPort)

// Reinitialize the protocol handler
handler = Protocol.ProtocolHandler.GetProtocolHandler(client, protocolversion, null, this);
Cookies = savedCookies; // Restore cookies for the new connection before login
Log.Info($"Connected to {resolvedHost}:{resolvedPort}");

// Retry login process
Expand Down