fix(build): bump macOS deployment target to 15.0 - #7
Closed
Cyb3rDudu wants to merge 1 commit into
Closed
Conversation
DirectPipe fails to build on current macOS SDKs. With 10.15 set, the newer CoreGraphics headers define CGToneMapping (added in macOS 15) and clang treats the unguarded availability as a hard error (-Werror): 'CGToneMapping' is only available on macOS 15.0 or newer. Set the minimum macOS version to 15.0 so it compiles cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the macOS deployment target from 10.15 to 15.0 in CMakeLists.txt.
Why
The project doesn't build with current Xcode/macOS SDKs. With 10.15 set, the newer CoreGraphics headers define
CGToneMapping(added in macOS 15), and clang treats the unguarded availability as a hard error:I hit this on Apple Silicon with the July CommandLineTools SDK. Setting
CMAKE_OSX_DEPLOYMENT_TARGETto 15.0 fixes it; the build completes cleanly (host app + tests, arm64).Impact
Notes
Tested locally on arm64, macOS 15. Built the .app +
directpipe-host-testswith CMake 4.3 + clang 21. Did not run the full test suite.