fix: size the check icons like the state balls next to them - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check icons in the host and service lists were rendered at 3em (2em in
minimal lists) while the state ball right next to them measures 2em and 1.5em
respectively. The theme now sizes them to the ball's visible circle, which is
the outer box minus
@ball-padon each side, and shifts them down so both siton the same line. The detail header needs its own offset because upstream pulls
the icon up to the row edge there.
The rules carry the
.icinga-module.module-icingadbprefix, otherwise theycannot reach the specificity of the upstream ones: Icinga Web wraps module CSS
in
.icinga-module.module-<name>. Both the current (item-layout) and thepre-1.2 (
item-list) class names are covered.Also adds the missing
CHANGELOG.mdand bumps the version to 1.1.2.