Skip to content

[codex] polish POSIX signal wake follow-up - #11

Merged
LimiNode merged 1 commit into
mainfrom
codex/polish-posix-signal-wake-review
Jun 9, 2026
Merged

[codex] polish POSIX signal wake follow-up#11
LimiNode merged 1 commit into
mainfrom
codex/polish-posix-signal-wake-review

Conversation

@LimiNode

@LimiNode LimiNode commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary

Small follow-up polish for the POSIX signal wake service review notes.

What Changed

  • Reset PosixSignalWakeComponent's shared service pointer before stopping the service.
  • Added a comment explaining why the signal wake fd is stored as sig_atomic_t.
  • Cleaned up the Russian README wording around the opt-in self-pipe wake component.

Validation

  • cmake --build tmp/agent-work/build-runner-mingw --target test_console_application_runner test_loop_throttle_component --parallel 1
  • ctest --test-dir tmp/agent-work/build-runner-mingw -R "test_console_application_runner|test_loop_throttle_component" --output-on-failure -> 2/2 passed
  • cmake --build tmp/agent-work/build-runner-cxx11-mingw --target test_console_application_runner test_loop_throttle_component --parallel 1
  • ctest --test-dir tmp/agent-work/build-runner-cxx11-mingw -R "test_console_application_runner|test_loop_throttle_component" --output-on-failure -> 2/2 passed
  • rg -n '^\\s*#include .*\\.\\./' include -> no matches
  • git diff --check

@LimiNode
LimiNode marked this pull request as ready for review June 9, 2026 12:54
@LimiNode
LimiNode merged commit b7aa859 into main Jun 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant