fix(shell): lazy-load GlobalSearchDialog to meet client budget - #713
Merged
Conversation
Global search dialog chunks were eagerly bundled into the shell, pushing public route initial request counts over CI limits. Load the dialog on first open (Cmd+K) so catalog and home pages stay within budget.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
life-ustc | 1e7226a | Jul 31 2026, 03:27 PM |
worker.js imported CATALOG_EDGE_CACHE_TAG from catalog-runtime-cache, which evaluated Prisma and broke the E2E worker with fileURLToPath. Move the constant to a leaf module.
|
E2E HTML report is ready: https://life-ustc.github.io/e2e-snapshot-artifacts/reports/30642869322/index.html |
Scope catalog/admin search buttons away from the global search trigger, expect 24h CDN cache on catalog APIs, and tighten mobile topbar padding to avoid 280px horizontal overflow.
The shell now owns Ctrl/Cmd+K for global search, so the dashboard links page test should click its local searchbox instead of expecting the shortcut to focus it.
Extend global search with campus link results, a dedicated /search page, keyboard navigation, and teacher-before-section ranking. Match links across all locales and route /search through the dynamic SSR bypass.
Lazy-loaded global search adds one initial asset request to the shared layout graph while gzip size stays within existing limits.
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 31, 2026
# [1.82.0](v1.81.1...v1.82.0) (2026-07-31) ### Bug Fixes * **search:** harden global search dialog and local dev setup ([d9c3a8d](d9c3a8d)) * **search:** resolve CI type errors and update OpenAPI spec ([8cdffc1](8cdffc1)) * **search:** unblock Chinese IME queries in global search dialog ([cc315f9](cc315f9)) * **search:** wire dialog input updates for Svelte 5 Input component ([573404b](573404b)) * **shell:** lazy-load GlobalSearchDialog to meet client budget ([#713](#713)) ([d4cde98](d4cde98)) ### Features * **search:** add global search and fix calendar export freshness ([#708](#708)) ([241e917](241e917))
|
🎉 This PR is included in version 1.82.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobalSearchDialoginAppShellinstead of a static import so global search chunks are not part of the initial shell bundle.Fixes E2E CI
public-route-client-budget.test.shrequest-count failures introduced by global search (#708):/: 60 → 56 requests (limit 56)/catalog/courses/[jwId]: 95 → 93 (limit 93)/catalog/sections/[jwId]: 104 → 103 (limit 103)Test plan
bash tests/ci/public-route-client-budget.test.shbunx biome check src/lib/components/shell/AppShell.sveltebunx svelte-checkBuild E2E artifactsgreen