Fix inverted XDP copy/zero-copy bind flag handling - #221
Open
jason-sirius wants to merge 1 commit into
Open
Conversation
TRACE_OPTION_XDP_ZERO_COPY_MODE set XDP_COPY, TRACE_OPTION_XDP_COPY_MODE set XDP_ZEROCOPY, and TRACE_OPTION_XDP_SKB_MODE forced XDP_ZEROCOPY despite the comment saying SKB requires copy mode (the kernel rejects ZEROCOPY binds in SKB mode with EOPNOTSUPP). The mask operations were also wrong: `flags &= XDP_COPY` keeps only the copy bit rather than clearing it, so the intent of "clear the other mode, set the requested one" was never expressed. Use `&= ~other` + `|= requested` in all three cases. The doc comments for the two options in libtrace.h.in were swapped the same way; fix those to match the option names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRACE_OPTION_XDP_ZERO_COPY_MODE set XDP_COPY, TRACE_OPTION_XDP_COPY_MODE set XDP_ZEROCOPY, and TRACE_OPTION_XDP_SKB_MODE forced XDP_ZEROCOPY despite the comment saying SKB requires copy mode (the kernel rejects ZEROCOPY binds in SKB mode with EOPNOTSUPP).
The mask operations were also wrong:
flags &= XDP_COPYkeeps only the copy bit rather than clearing it, so the intent of "clear the other mode, set the requested one" was never expressed. Use&= ~other+|= requestedin all three cases.The doc comments for the two options in libtrace.h.in were swapped the same way; fix those to match the option names.