fix: stabilize CSS bundles across platforms - #2
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dsh-token-usage_[local]CSS Module namespace instead of Lightning CSS's platform-sensitive path hashRoot cause
The existing configuration normalized checkout-relative paths but still used Lightning CSS's built-in
[hash]. Historical CI showed that Windows-generated committed bundles used different CSS Module prefixes from an Ubuntu rebuild. The first revision of this PR proved that even identical POSIX input strings are interpreted with host-specific path semantics inside Lightning CSS, so path normalization alone was insufficient. The final fix removes path hashing from class names and uses the plugin ID as a deterministic collision namespace.The CI correctly retained
git diff --exit-code -- lib; no quality gate was disabled. Typecheck, tests, package validation, and same-run deterministic builds were already passing before the final cross-platform check.Verification
npm run typecheck— passednpm test— 23 files, 135 tests passednpm run buildruns produced identical SHA-256 values forlib/index.js,lib/client.js, andlib/client.js.mapnpm pack --dry-run --json— 41 files validatedgit diff --check— passedThe remaining acceptance check is the pull request's Ubuntu CI rebuild matching the bundle generated on Windows.