notify resource owner when admin shares or unshares - #118
Open
fabracht wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #110.
_sharesrecords with an empty ownership config, and the delete path precomputes event recipients from that config, sorecord_ownerreturnedNoneand the owner was silently omitted on every unshare (single and cascade).share_revoke → clear_grant → delete_grants, pluswrite_grant/clear_all_resource_grants), so the owner is resolved while the resource record is still live.None(the resource is already gone by then), which is out of scope here; the grantee is still notified in that path.Test plan
test_unshare_by_admin_notifies_ownerdrives real Share/Unshare requests as an admin and asserts the emitted_sharesdelete event reaches both owner and grantee; verified it fails without the fix (owner missing) and passes with it