allow non-admin publish to the subscribe request channel - #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
Summary
mqdb subscribewas blocked for non-admin users:$DB/_sub/subscribe(and the$DB/_sub/{id}/heartbeat/unsubscribecontrol topics it publishes) were treated as internal$DB/_*topics and rejected withinternal entity access deniedWriteOnlyprotection tier (the counterpart toReadOnly) and gates$DB/_sub/#with it: any authenticated user may publish subscribe requests (still subject to ACL, like a normal topic), but subscribing to$DB/_sub/#is denied for non-service clients so one user cannot snoop another's requests or response topics_subto the internal-entity allowlist" because that would also allow non-admin subscribe to the request channel (request snooping / response spoofing); the CLI only ever publishes therehandle_subscribehas no separate admin gateTest plan
check_access_sub_channel_write_only— publish allowed, subscribe denied (incl. admin) for$DB/_sub/*$DB/_sub/subscribe/heartbeat, non-admin cannot subscribe to$DB/_sub/#, internal service can consumemqdb subscribe, got a subscription (no denial), and received a change event on a create