Skip to content

Project admins should be able to view user details from the project user page #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-klum wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Project admins should be able to view user details from the project user page #7854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions core/src/org/labkey/core/user/UserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,11 +1587,10 @@ public ModelAndView getView(UserQueryForm form, BindException errors)
if (schema == null)
throw new NotFoundException(CoreQuerySchema.NAME + " schema");

// use getTable(forWrite=true) because we hack on this TableInfo
// TODO don't hack on the TableInfo, shouldn't the schema check canSeeUserDetails() and has AdminPermission?
TableInfo table = schema.getTable(CoreQuerySchema.SITE_USERS_TABLE_NAME, null, true, true);
String tableName = isUserManager ? CoreQuerySchema.SITE_USERS_TABLE_NAME : CoreQuerySchema.USERS_TABLE_NAME;
TableInfo table = schema.getTable(tableName, null, true, true);
if (table == null)
throw new NotFoundException(CoreQuerySchema.SITE_USERS_TABLE_NAME + " table");
throw new NotFoundException(tableName + " table");
else if (table instanceof AbstractTableInfo)
{
// conditionally remove the email and groups columns only for this view
Expand Down