ci: Add CI for automatic release - #378
Open
mhovd wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Release Please automation to maintain a rolling release PR on main, generate a CHANGELOG.md, and publish GitHub Releases with version tracking aligned to the R package metadata.
Changes:
- Add Release Please configuration + manifest to track and bump versions from
3.2.4. - Add a GitHub Actions workflow to run
googleapis/release-please-action@v4on pushes tomain. - Update R package metadata/build ignore rules to accommodate generated release artifacts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
release-please-config.json |
Defines Release Please behavior (simple release type, changelog sections, and extra file updates). |
DESCRIPTION |
Adds Release Please version markers around the Version: field. |
.release-please-manifest.json |
Seeds Release Please manifest with current version (3.2.4). |
.Rbuildignore |
Excludes Release Please artifacts and generated changelog/version files from R package builds. |
.github/workflows/release-please.yaml |
Adds CI workflow to run Release Please on pushes to main. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 51 51
Lines 22409 22409
=======================================
Hits 13868 13868
Misses 8541 8541 🚀 New features to boost your workflow:
|
att_amend_desc() in dev_history.R rewrites DESCRIPTION via desc, which strips the x-release-please marker comments. Release-please would then silently stop bumping Version, publishing a release whose DESCRIPTION reports the old one. Assert the markers exist and that DESCRIPTION matches the manifest.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Flagged by CodeQL on PR #378. The workflow only checks out and builds, so contents: read is sufficient. Matches pkgdown, test-coverage and release-please, which already declare explicit permissions.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/R-CMD-check.yaml:118
- The version-sync job checks that the marker lines exist, but it doesn't verify they actually surround the
Version:field. If the markers are moved away fromVersion:(orVersion:is moved outside the markers), this job would still pass even though release-please would no longer be able to bump the package version correctly.
# write.dcf() and desc::desc_set() silently drop comment lines, which
# would stop release-please bumping Version with no error anywhere.
for marker in '# x-release-please-start-version' '# x-release-please-end'; do
if ! grep -qxF "$marker" DESCRIPTION; then
echo "::error file=DESCRIPTION::Missing '$marker'. release-please can no longer update Version; restore the marker."
exit 1
fi
done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.