RHI: normalize cross-backend capability reporting and add parity coverage by Krilliac · Pull Request #441 · Krilliac/SparkEngine

Krilliac · 2026-04-09T11:08:23Z

Motivation

Backend capability structs were populated inconsistently across RHI implementations causing feature flags (especially ray-tracing related) to diverge between backends and fallback paths.
Keep runtime feature gating and higher-level systems stable by ensuring every backend exposes coherent, clamped capability values.

Description

Add FinalizeDeviceCapabilities(RHIDeviceCapabilities&) in Graphics/RHI/RHITypes.h to sync legacy RT booleans with detailed RTCapabilities, clear incoherent fields, and clamp minimum capability values.
Invoke FinalizeDeviceCapabilities from each backend initialization path: D3D11, D3D12, Vulkan, OpenGL (after capability query), and NullRHIDevice (on Initialize) so all backends report normalized capabilities.
Improve OpenGL reporting by detecting software renderers (llvmpipe / softpipe), setting isSoftwareDevice, and mapping GL compute-based fallbacks to RayTracingBackend::Software_SDFGI when appropriate.
Add unit test Tests/TestRHICapabilityParity.cpp which verifies RT flag syncing, incoherent RT field cleanup, VRS consistency, and clamping of minimum capability values.

Testing

Ran formatting with clang-format -i on modified files successfully.
Ran CMake configure via cmake --preset linux-gcc-release which completed successfully and generated build files.
Started cmake --build build/linux-gcc-release --config Release -j4; the full tree build was large and the build run in-session did not complete to finish all targets.
Added the test file Tests/TestRHICapabilityParity.cpp (not executed with ctest in-session due to the incomplete full build).

Codex Task

chatgpt-codex-connector · 2026-04-09T11:08:29Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

github-actions · 2026-04-09T11:41:47Z

❌ CI Error Report

Failed jobs: windows-vs2022-Release
Errors: 0 | Test failures: 4 | Warnings: 0

Test Failures

Test	Jobs
1/1 Test #1: SparkEngineTests .................***Failed 12.68 sec	windows-vs2022-Release
[ FAILED ] LoadTest_Severe_NetworkChurn (11.1ms, 2 assertions)	windows-vs2022-Release
[ FAILED ] Integration_NetworkingECS_ReplicationLatencyJitterPredictionReconciliation (749us, 8 assertions)	windows-vs2022-Release
0% tests passed, 1 tests failed out of 1	windows-vs2022-Release

Updated: 2026-04-09T19:42:16Z — this comment is updated in-place, not duplicated.

github-actions · 2026-04-09T13:08:02Z

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23716| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem	Lines	Hit	Coverage	Threshold	Status
AI	2776	694	25%	35%	❌
Animation	160	154	96.2%	35%	✅
Audio	0	0	0%	30%	✅
Camera	0	0	0%	40%	✅
Core	2248	1394	62%	40%	✅
ECS	190	114	60%	40%	✅
Editor	5997	1864	31.1%	25%	✅
GameModules	6244	3130	50.1%	30%	✅
Graphics	7202	3792	52.7%	30%	✅
Networking	3379	2240	66.3%	35%	✅
Physics	0	0	0%	35%	✅
Scripting	0	0	0%	30%	✅
Utils	7687	4865	63.3%	60%	✅

Total: 50.9% (18247/35883 lines)

github-actions · 2026-04-09T13:41:48Z

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23727| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem	Lines	Hit	Coverage	Threshold	Status
AI	2776	694	25%	35%	❌
Animation	160	154	96.2%	35%	✅
Audio	0	0	0%	30%	✅
Camera	0	0	0%	40%	✅
Core	2248	1394	62%	40%	✅
ECS	190	114	60%	40%	✅
Editor	5997	1864	31.1%	25%	✅
GameModules	6244	3131	50.1%	30%	✅
Graphics	7202	3795	52.7%	30%	✅
Networking	3379	2247	66.5%	35%	✅
Physics	0	0	0%	35%	✅
Scripting	0	0	0%	30%	✅
Utils	7687	4865	63.3%	60%	✅

Total: 50.9% (18258/35883 lines)

github-actions · 2026-04-09T18:50:44Z

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23727| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem	Lines	Hit	Coverage	Threshold	Status
AI	2776	694	25%	35%	❌
Animation	160	154	96.2%	35%	✅
Audio	0	0	0%	30%	✅
Camera	0	0	0%	40%	✅
Core	2248	1394	62%	40%	✅
ECS	190	114	60%	40%	✅
Editor	5997	1864	31.1%	25%	✅
GameModules	6244	3131	50.1%	30%	✅
Graphics	7202	3795	52.7%	30%	✅
Networking	3379	2247	66.5%	35%	✅
Physics	0	0	0%	35%	✅
Scripting	0	0	0%	30%	✅
Utils	7687	4865	63.3%	60%	✅

Total: 50.9% (18258/35883 lines)

github-actions · 2026-04-09T19:30:20Z

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23727| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem	Lines	Hit	Coverage	Threshold	Status
AI	2776	694	25%	35%	❌
Animation	160	154	96.2%	35%	✅
Audio	0	0	0%	30%	✅
Camera	0	0	0%	40%	✅
Core	2248	1394	62%	40%	✅
ECS	190	114	60%	40%	✅
Editor	5997	1864	31.1%	25%	✅
GameModules	6244	3131	50.1%	30%	✅
Graphics	7202	3795	52.7%	30%	✅
Networking	3379	2247	66.5%	35%	✅
Physics	0	0	0%	35%	✅
Scripting	0	0	0%	30%	✅
Utils	7687	4865	63.3%	60%	✅

Total: 50.9% (18258/35883 lines)

RHI: normalize backend capabilities and add parity tests

5359637

Krilliac added the codex label Apr 9, 2026 — with ChatGPT Codex Connector

Krilliac added 2 commits April 9, 2026 06:52

Fix GameplayTags overload ambiguity and crash write warning

07067d1

Fix CMake export set dependencies for SparkEngineLib

55d8ef3

Fix Windows ComPtr compile issue and run project formatting

5ed0c9b

Krilliac added 3 commits April 9, 2026 13:25

Qualify ComPtr usage in PerformanceProfiler Windows capture paths

faab615

Stabilize networking integration tests to reduce CI flakiness

712f57e

Sync third-party manifest after CMake dependency wiring changes

f246ba8

Fix remaining clang-format violation in collaborative session loop

5d84048

Krilliac merged commit 4aa4d9b into Working Apr 9, 2026
3 checks passed

Krilliac deleted the codex/evaluate-and-sync-rendering-backends branch April 9, 2026 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHI: normalize cross-backend capability reporting and add parity coverage#441

RHI: normalize cross-backend capability reporting and add parity coverage#441
Krilliac merged 8 commits into
Workingfrom
codex/evaluate-and-sync-rendering-backends

Krilliac commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Krilliac commented Apr 9, 2026

Motivation

Description

Testing

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ CI Error Report

Test Failures

Uh oh!

github-actions Bot commented Apr 9, 2026

Code Coverage (GCC + lcov)

Per-Subsystem Coverage

Uh oh!

github-actions Bot commented Apr 9, 2026

Code Coverage (GCC + lcov)

Per-Subsystem Coverage

Uh oh!

github-actions Bot commented Apr 9, 2026

Code Coverage (GCC + lcov)

Per-Subsystem Coverage

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Code Coverage (GCC + lcov)

Per-Subsystem Coverage

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 9, 2026 •

edited

Loading