Skip to content

Claude/restore test coverage 9 nyn9#402

Merged
Krilliac merged 3 commits into
Workingfrom
claude/restore-test-coverage-9Nyn9
Apr 7, 2026
Merged

Claude/restore test coverage 9 nyn9#402
Krilliac merged 3 commits into
Workingfrom
claude/restore-test-coverage-9Nyn9

Conversation

@Krilliac

@Krilliac Krilliac commented Apr 6, 2026

Copy link
Copy Markdown
Owner

No description provided.

claude added 2 commits April 6, 2026 23:23
@claude
Restore test coverage improvements from PR #329
8e400d0 
- Fix Split("", ',') crash: replace std::istringstream with find-based
  parsing to handle empty strings safely
- Add TestThreadDebugger.cpp with 22 tests covering edge cases, null
  args, disabled mode, report smoke tests, and macro compilation
- Add scripts/coverage-report.sh for per-subsystem coverage analysis
  with configurable thresholds and JSON output
- Enhance CI coverage job: add game modules, verbose test output,
  per-subsystem analysis step, and enriched PR comment with threshold
  pass/fail table

https://claude.ai/code/session_016pN7BUHr5SksZ43YFVxvFV
@claude
Update badge timestamp
e08579f 
https://claude.ai/code/session_016pN7BUHr5SksZ43YFVxvFV
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/MemoryDebugger.h                         |13.3%   150| 0.0%  20|    -    0
Utils/MemoryMonitor.cpp                        | 9.6%   229| 0.0%  19|    -    0
Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |21.8%    87| 0.0%  16|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |6700%     1| 0.0%   1|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.9% 22677| 0.0%  3k|    -    0

Per-Subsystem Coverage

Subsystem Lines Hit Coverage Threshold Status
AI 2776 694 25% 35% ❌
Animation 160 154 96.2% 35% ✅
Audio 0 0 0% 30% ✅
Camera 0 0 0% 40% ✅
Core 2153 1326 61.6% 40% ✅
ECS 161 103 64% 40% ✅
Editor 5966 1855 31.1% 25% ✅
GameModules 6161 2871 46.6% 30% ✅
Graphics 7026 3641 51.8% 30% ✅
Networking 3320 2096 63.1% 35% ✅
Physics 0 0 0% 35% ✅
Scripting 0 0 0% 30% ✅
Utils 7424 4620 62.2% 60% ✅

Total: 49.4% (17360/35147 lines)

@github-actions

github-actions Bot commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: windows-vs2022-Release
Errors: 0 | Test failures: 11 | Warnings: 0

Test Failures

Test Jobs
1/1 Test #1: SparkEngineTests .................***Failed 12.42 sec windows-vs2022-Release
[ FAILED ] Racing_TrackSystem_Initialize (539us, 1 assertions) windows-vs2022-Release
[ FAILED ] Racing_TrackSystem_LoadDemoTrack (477us, 1 assertions) windows-vs2022-Release
[ FAILED ] Racing_TrackSystem_GetTrackCount (907us, 1 assertions) windows-vs2022-Release
[ FAILED ] Racing_TrackSystem_GetCheckpointCount (846us, 1 assertions) windows-vs2022-Release
[ FAILED ] Racing_RaceManager_Initialize (536us, 1 assertions) windows-vs2022-Release
[ FAILED ] Platformer_Checkpoint_Initialize (513us, 1 assertions) windows-vs2022-Release
[ FAILED ] Platformer_Checkpoint_CountAndActivated (807us, 2 assertions) windows-vs2022-Release
[ FAILED ] Platformer_Player_Initialize (483us, 2 assertions) windows-vs2022-Release
[ FAILED ] Platformer_Player_RespawnRestoresPosition (2.6ms, 3 assertions) windows-vs2022-Release
0% tests passed, 1 tests failed out of 1 windows-vs2022-Release

Updated: 2026-04-07T01:24:31Z — this comment is updated in-place, not duplicated.

@Krilliac
Krilliac merged commit 1596ebf into Working Apr 7, 2026
37 of 39 checks passed
@Krilliac
Krilliac deleted the claude/restore-test-coverage-9Nyn9 branch April 7, 2026 00:54
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/MemoryDebugger.h                         |13.3%   150| 0.0%  20|    -    0
Utils/MemoryMonitor.cpp                        | 9.6%   229| 0.0%  19|    -    0
Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |21.8%    87| 0.0%  16|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |6700%     1| 0.0%   1|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.9% 22679| 0.0%  3k|    -    0

Per-Subsystem Coverage

Subsystem Lines Hit Coverage Threshold Status
AI 2776 694 25% 35% ❌
Animation 160 154 96.2% 35% ✅
Audio 0 0 0% 30% ✅
Camera 0 0 0% 40% ✅
Core 2153 1326 61.6% 40% ✅
ECS 161 103 64% 40% ✅
Editor 5966 1855 31.1% 25% ✅
GameModules 6161 2871 46.6% 30% ✅
Graphics 7026 3643 51.9% 30% ✅
Networking 3320 2096 63.1% 35% ✅
Physics 0 0 0% 35% ✅
Scripting 0 0 0% 30% ✅
Utils 7424 4620 62.2% 60% ✅

Total: 49.4% (17362/35147 lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krilliac @claude