Claude/fix slow tests 0y2wj#401
Merged
Merged
Conversation
Add missing EditorPanel.cpp and ARPGDungeonSystem.cpp to test sources, fix format specifier for uint64_t, suppress unused-variable warnings from disabled debug draw macros, and fix unsigned >= 0 comparisons. https://claude.ai/code/session_01GWZkHNsStxny6ZNZjFosjY
EditorLogger::Initialize() held m_mutex then called AddTarget() and Log(), both of which try to acquire m_mutex again. Since std::mutex is not recursive, this deadlocked on the first EditorLogger test (test #92), blocking all remaining ~3970 tests and making the suite appear to run "over an hour." Fix: push targets directly in Initialize() instead of calling AddTarget(), and move the Log() call outside the locked section. Remove the Log() call from Shutdown() which had the same deadlock pattern. Result: full test suite (4060 tests) now completes in ~14 seconds. https://claude.ai/code/session_01A9dweScVNKtmEFiSBdupKX
…bugs - OW systems (7 files): Remove overzealous null-context guards from Initialize() — none of the init logic uses the context pointer, so passing nullptr from tests is valid - MMO ChatSystem, Racing VehicleSystem: Same null-context fix - RTS KillUnit/DestroyBuilding: Actually remove entities from the map instead of just zeroing health, so GetUnitCount() reflects the kill - EditorLogger_ExportLogs: Write to CWD instead of missing TestLogs/ dir - CrashHandler_SaveAndHasRecoveryData: Create TestCrashes/ dir before use - Gated_VCS_SceneMergeHandler: Use correct .sparkscene extension All 4060 tests now pass in ~8.5 seconds. https://claude.ai/code/session_01A9dweScVNKtmEFiSBdupKX
Contributor
Code Coverage (GCC + lcov) |
Contributor
❌ CI Error ReportFailed jobs: windows-vs2022-Release Test Failures
Updated: 2026-04-06T23:28:17Z — this comment is updated in-place, not duplicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.