Make the release workflow a release check, and guard the README - #94
Merged
Conversation
Trusted publishing cannot work from this organization, so the publish step goes and the useful parts stay: the tag agrees with the version, the tests pass, and both artifacts land on the release. Uploads are manual now, and CONTRIBUTING says how and why.
Pictures are served over absolute URLs and there is no mermaid, since PyPI resolves a relative path against pypi.org and prints a mermaid fence as source text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trusted publishing cannot work from this organization, so the exchange fails whatever the project is configured with. 0.1.1 went out by hand. Rather than keep a workflow that looks functional and is not, the publish step goes and the parts worth having stay.
The workflow, on a published release:
CONTRIBUTING gains a release section with the steps: bump and lock, publish the release, then build and upload with a token that gets revoked afterward.
A guard for the thing that broke on the PyPI page:
Proven by mutation: making one image source relative again fails the first test. Note that twine check does not catch either problem, as it only asks whether a description renders, and the broken one rendered.
The pypi environment on the repo and the publisher registration on PyPI are left in place but dormant.