Feat/eval tracking support - #162
Open
camilobrownpinilla wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the VLM evaluation harness to optionally log evaluation metrics via KempnerForge’s existing metrics backends, and adds core checkpoint utilities to safely extract checkpoint “extra” metadata (e.g., a training run identifier) without restoring RNG state.
Changes:
- Added
load_train_state_extras()plus a sharedTRAIN_STATE_STANDARD_KEYSconstant to support reading checkpoint “extra” metadata without restoring RNG. - Enhanced
examples/vlm-evaluation/vlm_eval_harness.pyto accept dotted config overrides, derive a logging step, attach eval logs to a training run when possible, and emit structured eval metrics via a new benchmark manifest. - Added new benchmark manifest implementation and unit tests for checkpoint extras, benchmark manifest behavior, harness tracking glue, and adapter config loading.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_checkpoint_extras.py | Adds unit coverage for the new checkpoint “extras” accessor, including RNG non-application and ownership-gate behavior. |
| kempnerforge/checkpoint/state.py | Introduces TRAIN_STATE_STANDARD_KEYS and reuses it when extracting “extra” keys on restore. |
| kempnerforge/checkpoint/manager.py | Exposes load_train_state_extras() backed by the existing trusted _load_train_state() path. |
| kempnerforge/checkpoint/init.py | Exports load_train_state_extras as part of the public checkpoint API. |
| examples/vlm-evaluation/vlm_eval_harness.py | Adds config override forwarding, checkpoint step derivation, run-id attachment, and opt-in experiment tracking for eval results. |
| examples/vlm-evaluation/tests/unit/test_harness_tracking.py | Adds unit tests for the harness’s run-id resolution and tracking failure behavior. |
| examples/vlm-evaluation/tests/unit/test_benchmark_manifest.py | Adds thorough unit tests for benchmark aggregate resolution + metric flattening. |
| examples/vlm-evaluation/tests/unit/test_adapter.py | Ensures the harness can pass a pre-merged JobConfig through to the adapter without re-parsing. |
| examples/vlm-evaluation/README.md | Documents the new experiment tracking workflow and metric key scheme. |
| examples/vlm-evaluation/benchmark_manifest.py | Implements benchmark metric registry + normalized aggregate resolution and raw/perf metric flattening. |
| examples/vlm-evaluation/adapter.py | Allows config to be either a TOML path or an already-loaded JobConfig so CLI overrides reach the evaluated model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camilobrownpinilla
marked this pull request as ready for review
July 23, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uv run ruff check kempnerforge/ tests/passesuv run ruff format --check kempnerforge/ tests/ scripts/passesuv run pyright kempnerforge/passes (0 errors)uv run pytest tests/unit/ -v --timeout=60passesCloses #161