Correct supported time definitions for self-destruct flags - #2250
Merged
sk-keeper merged 3 commits intoJul 30, 2026
Merged
Conversation
Before: `[(m)inutes|(h)ours|(d)ays]` After: `[(mi)nutes|(h)ours|(d)ays|(mo)nths|(y)ears]`
Corrected the shorthand for minutes (`mi`, not `m`) Added `mo`nths and `y`ears definitions
Before: `[(m)inutes|(h)ours|(d)ays]` After: `[(mi)inutes|(h)ours|(d)ays|(mo)nths|(y)ears]`
sk-keeper
approved these changes
Jul 30, 2026
sk-keeper
pushed a commit
that referenced
this pull request
Jul 30, 2026
* Correct the help dialog for Record Add --self-destruct Before: `[(m)inutes|(h)ours|(d)ays]` After: `[(mi)nutes|(h)ours|(d)ays|(mo)nths|(y)ears]` * Correct self destruct time definitions Corrected the shorthand for minutes (`mi`, not `m`) Added `mo`nths and `y`ears definitions * Correct the help dialog for PAM Rotate --self-destruct Before: `[(m)inutes|(h)ours|(d)ays]` After: `[(mi)inutes|(h)ours|(d)ays|(mo)nths|(y)ears]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
record-addandpam action rotate, the help menu gives incorrect time definitions for--self-destruct:[(m)inutes|(h)ours|(d)ays]Changed to:
[(mi)nutes|(h)ours|(d)ays|(mo)nths|(y)ears]