Improve definitions for new-user flag in Enterprise Role - #2249
Closed
lthievenaz-keeper wants to merge 1 commit into
Closed
Improve definitions for new-user flag in Enterprise Role#2249lthievenaz-keeper wants to merge 1 commit into
lthievenaz-keeper wants to merge 1 commit into
Conversation
Enterprise Role command has a misleading flag for the default setting: `--new-user - assign this role to new users. 'add' only` The flag definition is vague and also suggests it can only be used in conjunction with `--add`, which is incorrect. Changes: - Renamed `--new-user` flag to `--default` - Changed help message to `Set this role as default for nodes and subnodes`
Contributor
Author
|
on second thoughts changing a flag like this may introduce breaking changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enterprise Role command has a misleading flag for the default setting:
--new-user - assign this role to new users. 'add' onlyThe flag definition is vague and also suggests it can only be used in conjunction with--add, which is incorrect.Changes:
--new-userflag to--defaultSet this role as default for nodes and subnodes