Start refactoring to model + checks modules (by adding checks for include files)#443
Open
gkreitz wants to merge 4 commits into
Open
Start refactoring to model + checks modules (by adding checks for include files)#443gkreitz wants to merge 4 commits into
gkreitz wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #398, we're heading in a direction where we want to split
verifyproblem.pyinto smaller parts. My plan is to add a model module, capturing the data, and a checks module, with all the checks.Untangling the current pieces gets messy quickly. So, for a first PR properly moving in this direction, I decided to add a "new" thing to the model - include files (which previously completely lacked any checks in verifyproblem), which serves to demonstrate/test the approach and how to integrate it into verifyproblem (without having to do all parts at once).
This PR:
buildfile to change compilation (this was never in the specs, and never supported by Kattis, nor can I spot any problems attempting to use it)run/toLanguage(will be needed for Entrypoint #388)Default include files are checked in this PR, but NOT supported (I opted not to touch
run/too much in this PR)