-
Notifications
You must be signed in to change notification settings - Fork 1
feat(pds-modal): add disableTopLayer to opt out of the browser top layer #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
70e9cca
feat(pds-modal): add disableTopLayer to opt out of the browser top layer
QuintonJason 64302cd
docs(pds-modal): document disableTopLayer with an overlay-above-modal…
QuintonJason 6abab99
fix(pds-modal): release focus in non-top-layer mode and simplify the …
QuintonJason cd44538
test(pds-modal): cover the disableTopLayer top-layer contract with e2e
QuintonJason 83d2b3a
docs(pds-modal): describe non-top-layer behavior accurately and make …
QuintonJason 1d43a15
fix(pds-modal): leave Escape to overlays that own focus in non-top-la…
QuintonJason 2ef45d4
test(pds-modal): cover Escape ownership for non-top-layer overlays in…
QuintonJason c16b5ac
docs(pds-modal): fix heading parse, clarify Escape behavior, auto-rem…
QuintonJason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.