Ensure uniqueness of sample nicks with nanoAOD version - #62
Open
sofiagiappichini wants to merge 6 commits into
Open
Ensure uniqueness of sample nicks with nanoAOD version#62sofiagiappichini wants to merge 6 commits into
sofiagiappichini wants to merge 6 commits into
Conversation
sofiagiappichini
requested review from
SimonSPD,
a-monsch,
jhvoss,
moritzmolch and
nshadskiy
August 17, 2026 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix was added to fold the NanoAOD version processing tag into the nick when the DAS name carries it (needed so that reprocessed versions of the same run/campaign don't collapse onto an identical nick). Most of the sample database predates that fix, so ~3,030 existing entries had a stored nick that no longer matched what the current code would generate from their dbs field (adding a version count at the end of the nick), while the biggest change is in Embedding and Data for Run2 that never specified the NanoAOD version and had duplicate nicks. This ensures no duplicated nicks are present and all samples can be run in one single call from KingMaker.
What this PR does: regenerates the nick for every entry where it doesn't match what _build_nick(dbs) currently produces, and renames the corresponding JSON file + updates the nick field + updates the matching key in that version's datasets.json cache to keep them in sync.
What was deliberately left untouched: 122 entries where regenerating the nick would have collided with another entry already using that name, or would have destroyed a hand-curated distinction the automatic derivation can't reconstruct from dbs alone — e.g.:
All renames were verified: every renamed file's content (besides nick) is unchanged, datasets.json key counts match the pre-change count exactly for all three versions (no entries lost), and no filename or datasets.json-key collisions were introduced.