Conversation
moritzmolch
left a comment
There was a problem hiding this comment.
General comments:
-
In the
.envfile, we define the python version to be3.9.*, while the LCG stack that we currently use inCROWNalready supports python 3.12. We should think about upgrading the python version in the KingMaker environment. -
We create a separate environment conda
env, meaning that we have two conda environments in the image:baseandenv. To my understanding, there is no reason why we need to create a encapsulated environment inside the container. We could just use thebaseenvironment.
|
This PR is now extended to include the move to a new container ( Regarding the point using the |
This pull request removes several Conda environment YAML files and refactors the command construction in the
runmethod ofprocessor/tasks/CROWNMain.pyto usewrap_executable_command.