Bump vite from 7.3.1 to 8.0.16 - #2
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.1 to 8.0.16. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.0.16/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.0.16 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
jaredmoody
pushed a commit
that referenced
this pull request
Sep 4, 2026
…arcoroth#2528) This pull request updates the dev server to notice templates that were already broken before it started, and to tell browsers about them when they connect. Indexing read every template but never parsed one, so `broken_files` started empty and nothing downstream knew a template was broken until someone touched it. Two things followed from that, and a third fell out of fixing them. #### Repairing a template the server indexed as broken Because the template was never recorded as broken, repairing it missed the recovery path entirely and fell through to the diff. The diff was computed against a previous source that does not parse, so the operations were meaningless: **Before** ``` 17:14:32.245 ↻ fetch app/views/posts/index.html.erb (2 operations) #1 node removed [0, 1] - HTML_OPEN_TAG (2:2) #2 node inserted [0, 1] + <form> ``` **After** ``` 17:18:45.909 ✓ clear app/views/posts/index.html.erb ``` `Watcher#index` now parses what it reads and records the templates that fail, the runner seeds its own set from that, and `Pipeline#remember_broken` marks them `:parse_error` so the clearing schema reaches browsers. Both entry points are wired, the CLI runner and the embedded boot in `Herb::Dev.boot`. Recovery also no longer prints a diff summary, since there is nothing meaningful to diff against. Parsing every template at startup costs about 45ms for 1000 templates, measured against the read that was already happening. #### Saying so at startup Now that indexing knows, the header says it: ``` Files: 453 templates indexed, 3 don't parse Files: 1 template indexed, 1 doesn't parse ``` The count goes through the existing `pluralize` helper, which also fixes `1 templates indexed`. #### Telling browsers on connect A browser that connects after the server started had no way to learn any of this. `Protocol.welcome` now carries the list, which is the one frame every browser receives regardless of when it shows up: ```json { "type": "welcome", "project": "/Users/marcoroth/Development/demos/reactionview-demo", "broken_files": [ "app/views/posts/index.html.erb", "app/views/posts/second.html.erb" ] } ``` `Server#on_welcome` takes a block the server calls per connection rather than a payload baked at startup, so a browser connecting after you repair something gets the shorter list. The client reports each one into the existing diagnostic sink, so they render as ordinary overlay cards: Follow up on marcoroth#2468 and marcoroth#2469.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vite from 7.3.1 to 8.0.16.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
f94df87release: v8.0.16dc245c7fix: reject windows alternate paths (#22572)50b9512fix(deps): reject UNC paths for launch-editor-middleware (#22571)8d1b019release: v8.0.152686d7dfix(deps): update all non-major dependencies (#22511)3052a67chore(deps): update rolldown-related dependencies (#22566)e3cfb9dfix(optimizer): close the rolldown bundle when write() rejects (#22528)6978a9crefactor: correct logic incollectAllModulesfunction (#22562)646dbedfeat: update rolldown to 1.0.3 (#22538)85a0efffix: capitalize error messages and remove spurious space in parse error (#22488)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.