Implement FEE skimmer with trigger-based event selection - #1182
Open
mgignac wants to merge 3 commits into
Open
Conversation
Fill in the FEESkimmer template, which previously returned true for every event. The selection is applied in steps; the first is the trigger skim, which requires an FEE trigger bit (TS bits 18/19) in the 2019+ TS bank, so it applies to the 2019 and 2021 running periods. Events with no TSBank fail. Top and bottom trigger counts are tracked separately and reported by MultiSkimDriver at end of job. Cuts are configurable through the same resource-file mechanism used by the V0 and Moller skimmers; downstream FEE kinematic cuts can be added after the trigger step. Also fix the FEE output/parameter file setters in MultiSkimDriver, which were unreachable from a steering file. lcsim maps an XML element to a setter by stripping "set" and lowercasing only the first character (JobControlManager.processDriverParameters), so setFEEParamFile could only be matched by <fEEParamFile>. Renaming to setFeeParamFile/setFeeOutputFile makes <feeParamFile>/<feeOutputFile> work and matches the v0 and moller naming. The private Skimmer field is renamed feeSkimmer so it no longer obscures the FEESkimmer class name. Verified on run 14185 (hps_014185.evio.00200, 5000 events): 4575 events processed, 90 passed (1.97%), 36 FEE top + 54 FEE bottom. The leading electron momentum in the skimmed events peaks at 3.775 GeV against a 3.742 GeV beam. Claude-Session: https://claude.ai/code/session_01UQzovHnJ6JBihqzYQpZE6J
Clone of PhysicsRun2021_pass5_recon_skimmed_dataqual_physics.lcsim with the
FEE skim enabled alongside the V0 skim, so a single job writes both
${outputFile}_v0skim.slcio and ${outputFile}_feeskim.slcio.
The KalmanPatRecDriver configuration is taken verbatim from
PhysicsRun2021MCRecon_KF_WithSpacing_pass6dev_lowp_physics_HitSmear_HitKill_14272.lcsim
so data and MC share the same pattern recognition: maxPtInverse 8.88 -> 12.0,
maxD0 39.25 -> 55.0, maxZ0 8.38 -> 20.0, minHits{Top,Bot}Iter2 8 -> 6,
maxSharedHits 2 -> 3, maxChi2IncShare 5.86 -> 8.0, lowPhThresh dropped, and the
explicit 23-entry seed strategy list with numStrategyIter1 17.
The MC file's RawTrackerHitFitterDriver settings (useTimestamps,
tsCorrectionScale, correctT0Shift, subtractTriggerTime, isMC) are deliberately
not carried over; those are MC timing calibrations rather than tracking
configuration, and the data values are kept.
Claude-Session: https://claude.ai/code/session_01UQzovHnJ6JBihqzYQpZE6J
The pass6dev steering file writes the FEE skim alongside the V0 skim in a single job, so the standalone FEE-only variant is redundant. Claude-Session: https://claude.ai/code/session_01UQzovHnJ6JBihqzYQpZE6J
bloodyyugo
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in the FEESkimmer template, which previously returned true for every event. The selection is applied in steps; the first is the trigger skim, which requires an FEE trigger bit (TS bits 18/19) in the 2019+ TS bank, so it applies to the 2019 and 2021 running periods. Events with no TSBank fail. Top and bottom trigger counts are tracked separately and reported by MultiSkimDriver at end of job. Cuts are configurable through the same resource-file mechanism used by the V0 and Moller skimmers; downstream FEE kinematic cuts can be added after the trigger step.
Also fix the FEE output/parameter file setters in MultiSkimDriver, which were unreachable from a steering file. lcsim maps an XML element to a setter by stripping "set" and lowercasing only the first character (JobControlManager.processDriverParameters), so setFEEParamFile could only be matched by . Renaming to setFeeParamFile/setFeeOutputFile makes / work and matches the v0 and moller naming. The private Skimmer field is renamed feeSkimmer so it no longer obscures the FEESkimmer class name.
Verified on run 14185 (hps_014185.evio.00200, 5000 events): 4575 events processed, 90 passed (1.97%), 36 FEE top + 54 FEE bottom. The leading electron momentum in the skimmed events peaks at 3.775 GeV against a 3.742 GeV beam.