Misc cleanup - #55
Merged
Merged
Conversation
this means effects after -v will not be applied
Catches the Architecture section up with the cleanu branch: prepath-keyed DataWorld, PlotTarget holding data, the Renderer/Renderer2 split (the PlotInfo setter-callback push mechanism is gone), TreeLabeler, and ensure_derived. Also drops the stale module-import-time config note. Co-Authored-By: Claude <noreply@anthropic.com>
lookup() keys on the bare prefix; passing the whole prepath silently lost every display name and unit for subdirectory prepaths. Co-Authored-By: Claude <noreply@anthropic.com>
lookup() keys on the bare prefix; passing the whole prepath silently lost the derived variable's display name and unit for subdirectory prepaths. Co-Authored-By: Claude <noreply@anthropic.com>
JamesMcClung
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messy commit with a few performance regressions to be cleaned up later.
Features/Changes
--copysupports 0 args (copies active var)--computesupports the shorthand-c(maybe confusing with copy...)--versusstores a copy of the data at the time of its invocation, and thus must be the last adaptor in the pipeline for a given plotInternal
DataWithAttrscachePlotInfocallbacksPlotTarget/Renderer/PlotInfo/Renderer2...