Begin macOS port: platform code paths + testable build process - #65
Draft
JRufer wants to merge 1 commit into
Draft
Begin macOS port: platform code paths + testable build process#65JRufer wants to merge 1 commit into
JRufer wants to merge 1 commit into
Conversation
Adds macOS as a build target and wires up a way to validate it before merging to master. Crate changes (all additive / cfg-gated; Linux and Windows unchanged): - voxctrl-mcp: bind the Unix-domain-socket server on any unix (macOS included) instead of Linux-only; add a non-unix/non-windows fallback. - voxctrl-routing: widen the mcp delivery client to unix; add a macOS text-injection path (pasteboard + osascript Cmd+V, mirroring the clipboard-paste fallback). - voxctrl-inject: add a macOS inject_text path (arboard + osascript). - voxctrl-hotkeys: rename the rdev listener (windows.rs -> rdev_backend.rs) and use it on macOS as well; add rdev to the macOS target deps. Build/config: - tauri.conf.json: add bundle.macOS (minimumSystemVersion). - src-tauri/Info.plist: microphone + Apple Events usage strings (required by macOS TCC or the app is killed on mic access). CI / release / testability: - ci.yml: add macos-14 to the cargo-check matrix (full workspace check). - macos-build.yml: NEW standalone preview workflow that builds the .app/.dmg on macos-14 and uploads them as artifacts. Runs on pushes to the macOS branch, on relevant PRs, and via manual dispatch, so the port can be tested without merging to master. - release.yml: add a macos-arm64 row producing VoxCtrl-macos-arm64.dmg, plus downloads-table entry and unsigned first-run instructions. Docs: docs/macos_build.md (build, TCC permissions, signing, CI) + index link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts the macOS (Apple Silicon) port and — importantly — wires up a way to build and test it in CI without merging to
master. All Rust changes are additive andcfg-gated, so Linux and Windows behavior is unchanged (verified: the four touched cratescargo checkclean andvoxctrl-routing/voxctrl-hotkeystests pass on Linux).Base branch is
development(there is nodevbranch;developmentis currently identical tomaster).How to test without merging to main
The new
.github/workflows/macos-build.yml("macOS Build (preview)") builds the.app+.dmgon amacos-14runner and uploads them as run artifacts. It triggers on:claude/macos-port-build(or anymacos-**branch) — already runs from this PR's pushes,Download the built app from the run's Artifacts section. Nothing in
release.yml(which only runs onmaster) is required to validate the port.Code paths added for macOS (all
cfg-gated)voxctrl-mcp— bind the Unix-domain-socket server on anyunix(macOS included) instead of Linux-only; added a non-unix/non-windows fallback.voxctrl-routing— widened themcpdelivery client tounix; added a macOS text-injection path (pasteboard +osascriptCmd+V, mirroring the existing clipboard-paste fallback).InjectTargetis the real dictation path, which previously returned "not supported" on macOS.voxctrl-inject— added a macOSinject_textpath (arboard+osascript).voxctrl-hotkeys— renamed the rdev listener (windows.rs→rdev_backend.rs) and reused it on macOS;rdev(already the Windows backend, supports macOS viaCGEventTap) added to the macOS target deps.Build config
tauri.conf.json— addedbundle.macOS(minimumSystemVersion).src-tauri/Info.plist—NSMicrophoneUsageDescription+NSAppleEventsUsageDescription(macOS terminates the app on mic access / Apple Events without these).CI / release
ci.yml— addedmacos-14to thecargo checkmatrix (full-workspace check, so the whisper.cpp/C++ crates and macOS platform code are compile-checked on every PR).release.yml— added amacos-arm64row producingVoxCtrl-macos-arm64.dmg, a downloads-table entry, and unsigned first-run instructions. Built without Moonshine for now (validate via the preview workflow first);fail-fast: falsekeeps the other platforms publishing.Docs
docs/macos_build.md— build steps, TCC permissions (Microphone / Accessibility / Input Monitoring), signing & notarization, and CI. Linked from the docs index.Known follow-ups (not in this PR)
entitlements.plist.macos-13) row.Test plan
macOS Build (preview)workflow goes green and produces a runnable.dmg/.appartifactcargo checkjob passes onmacos-14🤖 Generated with Claude Code
Generated by Claude Code