Bug: fix play with menu vis bug - #448
Open
kylebenzo wants to merge 3 commits into
Open
Conversation
JMBeresford
requested changes
Dec 7, 2025
Owner
There was a problem hiding this comment.
This is duplicated in #447 , please remove from this PR for clarity.
Owner
There was a problem hiding this comment.
This is duplicated in #447 , please remove from this PR for clarity.
Owner
There was a problem hiding this comment.
This is duplicated in #447 , please remove from this PR for clarity.
| <div | ||
| className={cn( | ||
| "flex relative", | ||
| "[&_*[data-radix-popper-content-wrapper]]:contents sm:[&_*[data-radix-popper-content-wrapper]]:block", |
Owner
There was a problem hiding this comment.
These classes are necessary for the popover to correctly render on mobile. Can we look into a different solution here?
It would be helpful to have a description of the root cause for this visual bug.
JMBeresford
force-pushed
the
main
branch
8 times, most recently
from
January 27, 2026 02:38
b46014c to
ee77021
Compare
JMBeresford
force-pushed
the
main
branch
18 times, most recently
from
February 5, 2026 01:08
3b579a9 to
da8f60d
Compare
JMBeresford
force-pushed
the
main
branch
25 times, most recently
from
February 8, 2026 00:58
2b76cc7 to
798c1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a visualization bug showing the "Play with" submenu on a game.