refactor(stm): Reuse the cached unsafe SRS in the SNARK test setups - #3443
Draft
damrobi wants to merge 4 commits into
Draft
refactor(stm): Reuse the cached unsafe SRS in the SNARK test setups#3443damrobi wants to merge 4 commits into
damrobi wants to merge 4 commits into
Conversation
Test Results 5 files ± 0 209 suites ±0 2h 35m 53s ⏱️ + 1h 33m 55s For more details on these failures, see this check. Results for commit e59acd2. ± Comparison against base commit 23e124d. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update to the way we use the unsafe SNARK setup in tests in order to reduce the runtime of the tests.
Gain in test time
Baseline: 1h11m47s (nightly 30/07 https://github.com/IntersectMBO/mithril/actions/runs/30506077425/job/90756011560)
After commit 1: 1h00m56s (https://github.com/IntersectMBO/mithril/actions/runs/30538872179/job/90858636858)
After commit 2: 40m50s (https://github.com/IntersectMBO/mithril/actions/runs/30552401815/job/90904114168?pr=3443)
After commit 3: 58m08s (https://github.com/IntersectMBO/mithril/actions/runs/30559800977/job/90929571831?pr=3443)
Pre-submit checklist
Comments
Issue(s)
Closes #3433