ci: add icc session helper - #1944
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PowerShell helper under .github/scripts/ to create a dated work-session directory name (DD-mmm-YYYY-NNN), and updates repository guidance/attributes so the helper is discoverable and checked out with consistent line endings.
Changes:
- Added
.github/scripts/icc-session.ps1session-directory creator with anicc-sessionalias. - Documented the helper in
.github/copilot-instructions.md. - Expanded
.gitattributesto enforce LF line endings for additional source/script extensions (including.ps1).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/scripts/icc-session.ps1 |
New PowerShell session helper script and alias for creating dated workspace directories. |
.github/copilot-instructions.md |
Adds a short usage pointer for the new Windows session helper. |
.gitattributes |
Enforces LF EOL for common source and script extensions, including the new .ps1 helper. |
Suppressed comments (1)
.github/scripts/icc-session.ps1:110
- If the script-level parameters are renamed to avoid clobbering the caller scope when dot-sourced, the direct-invocation call site must be updated to pass the renamed variables. As written, it still references
$Root/$Suffix/$Date/$NoLocation, so the script will stop accepting arguments after the rename.
if ($MyInvocation.InvocationName -ne ".") {
New-IccSession -Root $Root -Suffix $Suffix -Date $Date -NoLocation:$NoLocation
}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (3)
.github/scripts/icc-session.ps1:92
New-Itemuses-Pathhere as well, which applies wildcard expansion. If the resolved root contains wildcard characters, the child session directory creation may target the wrong location. Prefer-LiteralPathfor filesystem paths that should be treated verbatim.
$path = Join-Path $resolvedRoot $name
try {
New-Item -ItemType Directory -Path $path -ErrorAction Stop | Out-Null
break
.github/scripts/icc-session.ps1:110
Set-Alias -Scope Globalis executed unconditionally, butNew-IccSessiononly exists in the script scope unless the file is dot-sourced. If a user runs the script directly in an interactive session, this can leave a persistenticc-sessionalias that points to a non-existent command after the script exits.
Set-Alias -Name icc-session -Value New-IccSession -Scope Global
if ($MyInvocation.InvocationName -ne ".") {
New-IccSession -Root $Root -Suffix $Suffix -Date $Date -NoLocation:$NoLocation
}
.github/scripts/icc-session.ps1:66
New-Itemis called with-Pathwhen creating the root directory. In PowerShell-Pathapplies wildcard expansion, so roots containing wildcard characters (e.g.[,]) can be misinterpreted. Using-LiteralPathalso matches laterGet-ChildItem -LiteralPathusage and adding-ErrorAction Stopmakes failures explicit.
This issue also appears on line 89 of the same file.
$resolvedRoot = [System.IO.Path]::GetFullPath($Root)
New-Item -ItemType Directory -Path $resolvedRoot -Force | Out-Null
xsscx
force-pushed
the
ci-qa-pr-docker-testing
branch
from
August 1, 2026 22:50
9525bf5 to
6e9b935
Compare
Member
Author
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#1943
Checklist
docs/build.mddocs/ctest.mddocs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.