feat: support extracting envs from configmap as well - #66
Merged
Conversation
InftyAI-Agent
added
needs-triage
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
feat/support-env-in-modal
branch
from
August 18, 2026 17:49
061c5f2 to
a393d5b
Compare
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Aug 18, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
kerthcet
commented
Aug 18, 2026
| // readable by anything on the instance and by any principal holding that IAM | ||
| // permission. Acceptable while nothing sensitive rides on it; not a place to put a | ||
| // long-lived credential. | ||
| // TODO: deliver Secret-derived values out-of-band — SSM Parameter Store / Secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?