fix!: minimize argsort overloads#820
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argsortwith PyTorch parameter order #809.[[deprecated]]pre-feat: alignargsortwith PyTorch parameter order #809 compatibility interface.Motivation
#809 corrected the public parameter order but represented each Python default with another C++ overload. That unnecessarily expanded the API surface. C++ callers can pass the Python defaults explicitly while retaining the correct names and order.
This is a follow-up to #809; no standalone issue is associated with it.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A. This only removes convenience routing; the ATen implementation is unchanged.
Notes for Reviewers
API alignment
argsort(input, dim, descending, stable, out)outremains last perCONTRIBUTING.md.torch.argsort(input, dim=-1, descending=False, stable=False, *, out=None)argsort(input, stable, dim, descending, out)-1,false, andfalseexplicitly when they want PyTorch defaults.