Skip to content

feat: support MCCL on Moore Threads#52

Open
Ren-HL wants to merge 1 commit into
InfiniTensor:masterfrom
Ren-HL:feat/moore-mccl
Open

feat: support MCCL on Moore Threads#52
Ren-HL wants to merge 1 commit into
InfiniTensor:masterfrom
Ren-HL:feat/moore-mccl

Conversation

@Ren-HL

@Ren-HL Ren-HL commented Jul 23, 2026

Copy link
Copy Markdown

Summary

Add MCCL backend support for Moore Threads by reusing the shared MCCL CCL abstraction introduced in the current codebase. This PR adds the Moore MCCL provider alias, marks BackendType::kMccl with Device::Type::kMoore as a supported backend/device combination, and updates CMake so MCCL can be discovered and required for either MetaX or Moore Threads builds.

This keeps the platform/backend separation intact: Moore Threads does not duplicate MCCL operation implementations, and it can use the existing src/backends/ccl/mccl implementation through a small provider-specific api.h. It also completes the Moore runtime interface required by communicator initialization and reports BFloat16 as unsupported when it is not exposed by the Moore MCCL headers.

Changes

  • Moore MCCL Provider

    • Add src/backends/ccl/mccl/moore/api.h.
    • Bind CclApi<BackendType::kMccl, Device::Type::kMoore> to McclApi<Device::Type::kMoore>.
  • Backend/device support

    • Update src/backend_device_map.h so BackendType::kMccl is accepted with Device::Type::kMoore.
    • Add the missing musaGetDevice binding required by communicator initialization.
  • CMake detection and linking

    • Allow MCCL auto-detection when WITH_MOORE is enabled.
    • Add MUSA-style MCCL search hints from MUSA_ROOT, MUSA_HOME, MUSA_PATH, and /usr/local/musa.
    • Update the explicit WITH_MCCL requirement so MCCL accepts MetaX or Moore Threads GPU support.
    • Propagate the Moore MCCL type capability definition to internal example targets.
  • MCCL type support

    • Report BFloat16 as unsupported for Moore MCCL because the tested MCCL headers do not expose mcclBfloat16.
    • Preserve the existing MetaX MCCL BFloat16 behavior.
  • Documentation

    • Update README.md to document MCCL availability on Moore Threads.

Platform and Backend Affected

Platform

  • CPU
  • NVIDIA GPU
  • Iluvatar GPU
  • MetaX GPU
  • Moore Threads GPU
  • Cambricon MLU

Backend

  • OpenMPI
  • MPICH
  • NCCL
  • MCCL

Performance Impact

  • No performance impact
  • Performance improved
  • Performance regression possible

N/A.

Known Issues & Future Work

  • The tested MUSA 4.3.1 and MCCL 2.11.4 headers do not expose mcclBfloat16, so BFloat16 operations are reported as unsupported for Moore MCCL. If a future Moore MCCL version exposes native BFloat16 support, the provider capability can be updated accordingly.

Test Results

Test Involved Platform

  • CPU
  • NVIDIA GPU
  • Iluvatar GPU
  • MetaX GPU
  • Moore Threads GPU
  • Cambricon MLU

Test Involved Backend

  • OpenMPI
  • MPICH
  • NCCL
  • MCCL

Moore Threads with MCCL:

Test environment:

  • 8 × MTT S5000
  • MUSA 4.3.1
  • MCCL 2.11.4

Validation results:

  • 1-GPU Float32 AllReduce: expected 1, actual 1.
  • 2-GPU Float32 AllReduce: expected 3, actual 3.
  • 8-GPU Float32 AllReduce: expected 36, actual 36.
  • Moore and MCCL automatic detection passed.
  • The library and all internal examples built successfully.

ccl_all_reduce.log


Checklist

Every contributor must verify every item below before requesting
review. Tick each box only after the check has actually been performed —
do not tick speculatively. If an item truly does not apply, replace the
checkbox with N/A and briefly explain why in an inline comment.

Title, Branch, and Commits

  • PR title follows Conventional Commits (e.g. feat: …, fix(nccl): …).
  • Branch name follows <type>/xxx-yyyy-zzzz where <type> matches the PR title's Conventional Commits type and words are joined with hyphens (see CONTRIBUTING.md §Branches).
  • Each commit message follows Conventional Commits.
  • Small PR is a single squashable commit; or, for a large PR, every commit is meaningful, well-formed, and independently reviewable (see CONTRIBUTING.md §Pull Requests).
  • No stray merge commits from master — the branch is rebased cleanly on top of the current master.
  • No fixup! / squash! / wip commits remain.

Scope and Design

  • Changes are minimal — no unrelated modifications were introduced (CONTRIBUTING.md §Code/General).
  • No dead code, commented-out blocks, debug prints, printf/std::cout/print(...) left behind, or TODO without an owner and issue link.
  • No unrelated formatting churn that would obscure the diff.
  • N/A Public API changes (if any) are intentional, documented, and reflected in affected callers/tests.

General Code Hygiene

  • The code is self-explanatory; comments were added only where the intent or rationale is non-obvious (CONTRIBUTING.md §Code/General).
  • Every modified or added file ends with a single trailing newline (CONTRIBUTING.md §Code/General).
  • No trailing whitespace, inconsistent indentation, or mixed formatting styles remain.
  • Identifiers referenced in comments or error messages are wrapped in Markdown backticks (e.g. the `AllReduce` implementation) (CONTRIBUTING.md §Code/General).
  • All comments and error messages are in English (CONTRIBUTING.md §Code/General; §Python).
  • Comments and error messages are complete sentences — capitalized first letter, terminal punctuation — unless the language/framework convention says otherwise (CONTRIBUTING.md §Code/General; §Python).

C++ Specific (if C++ files changed)

  • Code follows the Google C++ Style Guide strictly.
  • clang-format (version 16, per .github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.
  • No exceptions are thrown. Error paths use assert with messages that include at least __FILE__, __LINE__, and __func__ (CONTRIBUTING.md §C++).
  • Error and warning message wording follows the LLVM Coding Standards (CONTRIBUTING.md §C++).
  • N/A Constructor initializer list order matches member declaration order (CONTRIBUTING.md §C++).
  • Exactly one blank line between classes, between classes and functions, and between functions (CONTRIBUTING.md §C++).
  • Exactly one blank line between members (functions and variables) within a class (CONTRIBUTING.md §C++).
  • Exactly one blank line before and after the contents of a namespace (CONTRIBUTING.md §C++).

Python Specific (if Python files changed)

  • N/A Code is PEP 8 compliant; ruff check passes cleanly on CI (see `.github/workflows/ruff.yml).
  • N/A ruff format --check passes cleanly — if not, run ruff format and commit the result.
  • N/A Comments are complete English sentences, starting with a capital letter and ending with punctuation; Markdown backticks are used for code references (CONTRIBUTING.md §Python).
  • N/A Framework-specific conventions (e.g. lowercase pytest.skip messages without terminal period) are honored.
  • N/A No blank line between the function signature and the body when there is no docstring or comment (CONTRIBUTING.md §Python).
  • N/A A blank line is present before and after if, for, and similar control-flow statements (CONTRIBUTING.md §Python).
  • N/A A blank line appears before each return, except when it directly follows a control-flow statement (CONTRIBUTING.md §Python).
  • N/A Docstrings (if any) follow PEP 257 (CONTRIBUTING.md §Python).
  • N/A Type hints are added / kept consistent with the surrounding code.

Testing

  • All applicable example programs have been built and tested successfully on at least one supported heterogeneous cluster setup.

Build, CI, and Tooling

  • New backends or devices have been added to auto-detection in CMakeLists.txt under if(AUTO_DETECT_DEVICES) or to if(AUTO_DETECT_BACKENDS) if applicable.
  • Both CI workflows (clang-format.yml, ruff.yml) are green locally (or expected to be green on CI).

Documentation

  • README.md, CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.
  • N/A Any user-visible breaking change is called out explicitly under "Summary" and in the commit/PR title with a ! or BREAKING CHANGE: footer.

Security and Safety

  • No secrets, access tokens, internal URLs, customer data, or personal hardware identifiers have been committed.
  • N/A Third-party code is license-compatible and attributed.
  • No unsafe pointer arithmetic, uninitialized reads, or missing bounds checks were introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant