Skip to content

Temporarily disable user registration - #1580

Merged
danlamanna merged 1 commit into
masterfrom
disable-registration
Aug 12, 2026
Merged

Temporarily disable user registration#1580
danlamanna merged 1 commit into
masterfrom
disable-registration

Conversation

@danlamanna

@danlamanna danlamanna commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Configuration
    • Disabled signup requests through rate limiting.
    • Existing rate limits for other account actions remain unchanged.

@danlamanna
danlamanna enabled auto-merge August 12, 2026 16:56
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Allauth settings now set the signup rate limit to 0/m/ip. Other rate-limit defaults remain unchanged.

Changes

Signup rate limiting

Layer / File(s) Summary
Configure signup rate limit
isic/settings/base.py
Adds ACCOUNT_RATE_LIMITS with a signup limit of 0/m/ip.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: brianhelba

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to disable user registration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disable-registration

Comment @coderabbitai help to get the list of available commands.

@danlamanna
danlamanna disabled auto-merge August 12, 2026 16:58
@danlamanna
danlamanna merged commit 8af9197 into master Aug 12, 2026
1 of 2 checks passed
@danlamanna
danlamanna deleted the disable-registration branch August 12, 2026 16:58

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@isic/settings/base.py`:
- Around line 144-147: Update the signup-shutdown configuration around
ACCOUNT_RATE_LIMITS so social signup is also rejected when signups are closed,
using the shared signup-closed gate or disabling social signup consistently with
the existing settings. Add a regression test covering configured Google
credentials and confirming that social signup cannot create a user.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a5b0c0b-7ed0-453d-8f53-a3185b0f4ba7

📥 Commits

Reviewing files that changed from the base of the PR and between 257e457 and 36d9a07.

📒 Files selected for processing (1)
  • isic/settings/base.py

Comment thread isic/settings/base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant