Allow assisted configuration of notifications - #1396
Merged
Conversation
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
3 times, most recently
from
July 23, 2026 09:00
861327a to
914dd1b
Compare
sukhwinder33445
suggested changes
Jul 23, 2026
sukhwinder33445
left a comment
sukhwinder33445
left a comment
Contributor
There was a problem hiding this comment.
The general Settings tab now shows two forms; please add a separator to visually distinguish them. For example , see the /account page.
sukhwinder33445
previously requested changes
Jul 27, 2026
sukhwinder33445
left a comment
sukhwinder33445
left a comment
Contributor
There was a problem hiding this comment.
Looks good so far.
I'll approve this PR as soon as the IcingaDB part has been implemented and this branch can be properly tested.
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
July 27, 2026 12:25
653d989 to
019b071
Compare
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
August 4, 2026 13:55
019b071 to
73c3998
Compare
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
August 14, 2026 11:38
73c3998 to
b053536
Compare
BastianLedererIcinga
marked this pull request as ready for review
August 14, 2026 11:43
nilmerg
requested changes
Aug 18, 2026
nilmerg
requested changes
Sep 3, 2026
nilmerg
requested changes
Sep 3, 2026
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
September 3, 2026 13:24
c5c6c54 to
a6a3201
Compare
nilmerg
requested changes
Sep 3, 2026
nilmerg
left a comment
nilmerg
left a comment
Member
There was a problem hiding this comment.
Managed to get this:
And the reason is that there is no source configured due to a database change. The toggle should not be on in this case and an appropriate warning should appear.
We should also think about a notice that tells the user the configuration looks fine, although the connection is unhealthy.
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
September 4, 2026 07:42
a6a3201 to
3ac79dd
Compare
nilmerg
requested changes
Sep 4, 2026
Add the `Config` model to represent the `icingadb_config` table, and declare the relation in `Environment`. Add columns necessary for assisted Icinga Notifications configuration to `Instance` guarded by `Backend::supportsNotifications()`
Rename the existing `Database` tab to `General Settings` and introduce `GeneralConfigForm`. In addition to the database configuration a toggle is added to (un)-configure Icinga Notifications. If the assisted configuration is not possible the toggle is locked with a callout explaining the reason.
BastianLedererIcinga
force-pushed
the
configure-notifications
branch
from
September 4, 2026 13:07
4dd40b1 to
7fdfd40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1356
This PR introduces the General Settings section, which contains the functionality of the previous Database section and also allows to configure Icinga Notifications.
GeneralConfigFormis introduced to support this.For the configuration of Icinga Notifications a toggle is added which, allows to enable/disable the Icinga Notifications integration, as long as it runs on the same system as Icinga DB and the two are connected by a Unix domain socket.
To achieve this this PR relies on a new table and modifications to the
instancetable.Enabling the toggle simply writes the discovered socket path(s) to in
icingadb_configand ensures Icinga Notifications has a matching source for each configured service user. Disabling it removes the rows fromicingadb_config, but will not touch the sources.Once row is written per endpoint found in
icingadb_instance, if theendpoint_idis null a a default value of 20 zero bytes is used, matching the daemons fallback.The toggle is disabled with a callout explaining why if:
icingadb_confighas a row withlocked=y, because a static configuration already exists.icingadb_instanceis found at allICINGADB_NOTIFICATIONS_SYNCHRONIZE_WITH_DATABASEis false