feat(chart): treat storage encryption keys as durable dependencies - #231
Merged
Conversation
Stop self-provisioning WAL and JetStream encryption keys in the Helm chart. Treat them as out-of-band dependencies matching S3/Anthropic patterns (D-31). - Default `create` flags to `false`. - Source keys from `.env` in Tilt to ensure persistence across dev restarts and prevent data loss from accidental rotation. - Add Helm template validation tests to verify secret generation posture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop self-provisioning WAL and JetStream encryption keys in the Helm chart. Treat them as out-of-band dependencies matching S3/Anthropic patterns (D-31).
createflags tofalse..envin Tilt to ensure persistence across dev restarts and prevent data loss from accidental rotation.Checklist
task ciis green locally (fmt-check, vet, lint, vulncheck, chart-lint, race, build) — GitHub doesn't runrace, so this is the only place it's checked.README.md§ Invariants /CONTRIBUTING.md§ "What gets reviewed hardest") — or, if it does, that's called out below.config/*/actions/catalog.yaml,config/*/hiss/policy.yaml,internal/actuate) — or, if it does, that's called out below.Closes #186