fix(telemetry): fix SLO integrity issues (PR1.6) - #11
Merged
Conversation
IanEff
force-pushed
the
fix/slo-integrity-pr1.6
branch
from
July 3, 2026 20:40
d107bb7 to
3562de8
Compare
- Filter ceph-osd-latency SLI queries to job="ceph-latency-bridge" and use le="102.399999" (ms units) to address falsified burn rates. - Wrap ceph-health SLI query in max() to aggregate away double-scraped mgr series. - Align prototype-observability.json dashboard panel queries with the updated OSD latency bucket/job. - Re-generate Prometheus recording and alerting rules via 'just gen-slos'. - Document gotchas regarding Sloth SLI aggregation and latency bridge units in CLAUDE.md and GEMINI.md. - Record actions in operations log.
IanEff
force-pushed
the
fix/slo-integrity-pr1.6
branch
from
July 3, 2026 20:40
3562de8 to
d2918e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR1.6 Fixes
This PR addresses the loose ends/SLO integrity bugs identified during verification of PR1.5:
T2 · OSD Latency False Alarm:
_bucketand_countqueries to{job="ceph-latency-bridge"}to isolate metrics and avoid count inflation from double-scraped sources.le="0.099999"tole="102.399999". Since the latency bridge exporter divides raw nanosecond values by1e6, y-axis values are in ms, meaning the ~100ms bucket matches102.399999ms.prototype-observability.jsonas well.T1 · Single Series per sloth_id:
ceph-healthraw SLI query inmax()to aggregate away multiple streams. This prevents double-scraped targets (likemgrpod scraped by bothkubernetes-podsandrook-ceph-mgr) from leaking duplicate series into the recorded metric.Gotcha Documentation:
CLAUDE.mdandGEMINI.mdto document the singleton series requirement for all Sloth SLIs and detail the OSD Performance Histogram units.