Complete removal of the legacy consent KV path#903
Draft
ChristianPavilonis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ec.ec_storeas the sole KV-backed EC identity/withdrawal store.consent_store, with explicit operator migration guidance.This PR is stacked on #902.
Changes
ConsentPipelineInput, delete the dead storage module, and removeConsentSource::KvStoreConsentConfig::consent_storeand add strict TOML/runtime-JSON rejection testsec.ec_storeMigration note
Deployments that still configure
[consent].consent_storemust remove the field before upgrading. Strict config loading intentionally rejects it. The old store may be retained unchanged for a rollback window, then unlinked and deleted; its records must not be copied intoec.ec_store.Closes
Closes #883
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serve— not runcargo test-cloudflare,cargo test-spin, parity,./scripts/test-cli.sh, all Cloudflare/Spin clippy targets, and all-features core rustdocChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)