Skip to content

Render SSAT winning creative inline without PBS Cache round trip #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prk-Jr wants to merge 11 commits into
base: main
Choose a base branch
from
+1,056 −91
Open

Render SSAT winning creative inline without PBS Cache round trip #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b56a0a1
Add design spec for SSAT inline creative rendering
prk-Jr Jul 13, 2026
6e8c48f
Add implementation plan for SSAT inline creative rendering
prk-Jr Jul 13, 2026
16e9d95
Correct plan call graph, add TsjsApi type + beacon steps, note precon…
prk-Jr Jul 13, 2026
34018e4
Revise SSAT inline-creative plan/spec per review
prk-Jr Jul 13, 2026
a1b844d
Refine plan test details per second review
prk-Jr Jul 13, 2026
6649875
Always include adm in bid map; gate only debug_bid blob
prk-Jr Jul 13, 2026
e2b13bb
Gate GAM-bypass adm injection on per-bid debug_bid
prk-Jr Jul 13, 2026
cb60fd2
Apply prettier formatting to spec/plan docs
prk-Jr Jul 13, 2026
1159407
Merge branch 'main' into feat/ssat-render-inline-creative
prk-Jr Jul 15, 2026
1c98302
Run SSAT inline creative through the sanitize/rewrite boundary and de…
prk-Jr Jul 16, 2026
d0b18b4
Emit absolute first-party URLs for inline SSAT creatives
prk-Jr Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 155 additions & 35 deletions crates/trusted-server-core/src/creative.rs
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions crates/trusted-server-core/src/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2730,7 +2730,7 @@ mod tests {
let settings = create_test_settings();
let clear = "https://cdn.example/asset.js?c=3&b=2&a=1";
// Simulate creative-generated first-party URL
let first_party = creative::build_proxy_url(&settings, clear);
let first_party = creative::build_proxy_url(&settings, clear, "");
// Reconstruct and validate (need absolute URL for parsing)
let st = reconstruct_and_validate_signed_target(
&settings,
Expand All @@ -2746,7 +2746,7 @@ mod tests {
fn reconstruct_valid_without_params() {
let settings = create_test_settings();
let clear = "https://cdn.example/asset.js";
let first_party = creative::build_proxy_url(&settings, clear);
let first_party = creative::build_proxy_url(&settings, clear, "");
let st = reconstruct_and_validate_signed_target(
&settings,
&format!("https://edge.example{}", first_party),
Expand All @@ -2763,7 +2763,7 @@ mod tests {
let settings = create_test_settings();
let clear = "ftp://cdn.example/file.gif";
// Build a first-party proxy URL with a token for the unsupported scheme
let first_party = creative::build_proxy_url(&settings, clear);
let first_party = creative::build_proxy_url(&settings, clear, "");
let req =
build_http_request(Method::GET, format!("https://edge.example{}", first_party));
let err: Report<TrustedServerError> =
Expand Down Expand Up @@ -2802,7 +2802,7 @@ mod tests {
futures::executor::block_on(async {
let settings = create_test_settings();
let clear = "https://cdn.example/landing.html?x=1";
let first_party = creative::build_click_url(&settings, clear);
let first_party = creative::build_click_url(&settings, clear, "");
let req =
build_http_request(Method::GET, format!("https://edge.example{}", first_party));
let resp = handle_first_party_click(&settings, &noop_services(), req)
Expand Down
Loading
Loading