This repository was archived by the owner on May 19, 2026. It is now read-only.
[SC 17745] Update collections import for 3.12 - #14
Closed
arron1993 wants to merge 4 commits into
Closed
Conversation
arron1993
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bit of a weird import, I didn't quite believe the docs at first i thought it was just a funky example, but
abcstands for abstract base class.Couldn't quite see which version of python this was changed in but 3.12 didn't like the original.
I've also renamed the tests to use the
test_convention, becausetestsis weird, I also added a small test for the header class because I was confused why the tests weren't error'ing. The test didn't help with this I needed to rebuild the container but I'll leave it anyway because it doesn't hurt.