GitHub直接インストーラーを追加 - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
新規の installer/Install-Plotree.bat が pause により終了コードを保持できず失敗時も 0 で終了しうるため、失敗検知が壊れる点の修正が必要です。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
GitHub Releases からの「直接インストール」用配布物(自己署名証明書+MSIX バンドル)を追加し、証明書の一致確認と信頼登録を伴うインストーラーフローを提供する PR です。あわせて、配布 ZIP 生成スクリプトと日英ドキュメント(README / リリースノート)に手順を追記しています。
Changes:
- MSIX バンドルと同梱
.cerの一致を検証して DirectInstaller ZIP を生成する PowerShell スクリプトを追加 - ZIP 内で証明書の一致・有効期限を検証し、必要時に管理者昇格して Trusted People に証明書を登録してからインストールする手順を追加
- README / RELEASE_NOTES に Microsoft Store と GitHub 直接インストールの案内を追加
File summaries
| File | Description |
|---|---|
| scripts/New-DirectInstaller.ps1 | DirectInstaller 用 ZIP を組み立てる生成スクリプトを追加 |
| installer/Install-Plotree.ps1 | 証明書検証・昇格・Trusted People 登録・MSIX インストールの実処理を追加 |
| installer/Install-Plotree.bat | PowerShell インストーラー起動用のバッチを追加 |
| installer/README.txt | ZIP 同梱のインストール手順(英日)を追加 |
| README.md | Store / GitHub 直接インストールの手順と ZIP 生成コマンドを追記 |
| README.ja.md | Store / GitHub 直接インストールの手順と ZIP 生成コマンドを追記 |
| RELEASE_NOTES.md | v1.0.4 のダウンロード手順に Store / DirectInstaller を追記 |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
配布
v1.0.4 の GitHub Release に
Plotree_1.0.4.0_DirectInstaller.zipを追加済みです。