Mark borel_weil_bott as internal - #9
Merged
Merged
Conversation
The theorem belongs to PartialFlagVarieties.jl, which now builds it out of the exported conjugate_dominant_weight_with_length; the copy kept here for the tests is internal, and the leading underscore says so.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
borel_weil_bottwas never exported, and its docstring already said it "properly belongs toPartialFlagVarieties.jl". That package now builds the theorem itself out of the exportedconjugate_dominant_weight_with_length, so nothing outside this package needs it. Renamed to_borel_weil_bott; no behaviour change.Call sites updated in
test/runtests.jl,docs/src/weyl.mdandbenchmark/bench.jl— the last imported the old name at line 19 and would have failed at load.Suite, doctests and the full docs build green (the latter resolves the
@docsentry and the@reffromis_singular);benchmark/bench.jlruns end to end, 230 benchmarks.