Add client-side command api - #380
Merged
Merged
Conversation
- Designed by dsh with deepseek-flash Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
- Designed by dsh with deepseek-flash Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
- Designed by dsh with deepseek-flash Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
- Designed by dsh with deepseek-v4-flash Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
|
Tick the box to add this pull request to the merge queue (same as
|
- Designed by dsh with deepseek-v4-flash Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a client-side command argument API to
magiclib-minecraft-api, porting the complete vanillanet.minecraft.commands.argumentsargument set so that client-side commands can be registered and used without a server-sideCommandSourceStack. All argument types bind to MagicLib'sClientCommandSourceinstead.The work follows the design of clientcommands / clientarguments, reusing the vanilla implementation wherever possible and only falling back to custom code when the vanilla counterpart is unavailable or inaccessible.
Test
AI-Coding
This PR introduces AI-Coding for the first time, all code has been human-reviewed. The code was designed by DeepSeek Harness, model: DeepSeek-V4-Flash-0731